refactor(auth): Use user_id as JWT sub and implement get_user_by_id

Switched from username to user_id as the primary identifier in JWT tokens to better support external authentication providers. Added get_user_by_id to HistoryManager and updated API dependencies and tests to reflect these changes.

tests/api/test_agent.py

@@ -15,7 +15,7 @@ def mock_user():
 @pytest.fixture
 def auth_header(mock_user):
     app.dependency_overrides[get_current_user] = lambda: mock_user
-    token = create_access_token(data={"sub": mock_user.username, "user_id": mock_user.id})
+    token = create_access_token(data={"sub": mock_user.id})
     yield {"Authorization": f"Bearer {token}"}
     app.dependency_overrides.clear()
 

tests/api/test_api_auth.py

@@ -92,10 +92,10 @@ def test_oidc_callback_success():
 def test_get_me_success():
     """Test getting current user with a valid token."""
     from ea_chatbot.api.utils import create_access_token
-    token = create_access_token(data={"sub": "test@example.com", "user_id": "123"})
+    token = create_access_token(data={"sub": "123"})
     
     with patch("ea_chatbot.api.dependencies.history_manager") as mock_hm:
-        mock_hm.get_user.return_value = User(id="123", username="test@example.com", display_name="Test")
+        mock_hm.get_user_by_id.return_value = User(id="123", username="test@example.com", display_name="Test")
         
         response = client.get(
             "/auth/me",

tests/api/test_api_history.py

@@ -18,7 +18,7 @@ def mock_user():
 def auth_header(mock_user):
     # Override get_current_user to return our mock user
     app.dependency_overrides[get_current_user] = lambda: mock_user
-    token = create_access_token(data={"sub": mock_user.username, "user_id": mock_user.id})
+    token = create_access_token(data={"sub": mock_user.id})
     yield {"Authorization": f"Bearer {token}"}
     app.dependency_overrides.clear()
 

tests/api/test_persistence.py

@@ -17,7 +17,7 @@ def mock_user():
 @pytest.fixture
 def auth_header(mock_user):
     app.dependency_overrides[get_current_user] = lambda: mock_user
-    token = create_access_token(data={"sub": mock_user.username, "user_id": mock_user.id})
+    token = create_access_token(data={"sub": mock_user.id})
     yield {"Authorization": f"Bearer {token}"}
     app.dependency_overrides.clear()
 

tests/test_workflow_history.py

@@ -25,6 +25,11 @@ def test_full_history_workflow(history_manager):
     assert user is not None
     assert user.display_name == "E2E User"
     
+    # 1.1 Verify get_user_by_id
+    fetched_user = history_manager.get_user_by_id(user.id)
+    assert fetched_user is not None
+    assert fetched_user.username == email
+    
     # 2. Create Conversation
     conv = history_manager.create_conversation(user.id, "nj", "Test Analytics")
     assert conv.id is not None